[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
Date: Tue, 22 Jan 2019 08:40:32 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

21.01.2019 18:17, Peter Maydell wrote:
On Mon, 21 Jan 2019 at 14:49, Anthony PERARD <address@hidden> wrote:

When Xen is detected via pkg-config, it isn't necessary to modify
LDFLAGS as modifying libs_softmmu is enough.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Anthony PERARD <address@hidden>
  configure | 1 -
  1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index 12fd34f30b..98b270974d 100755
--- a/configure
+++ b/configure
@@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
      QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
      libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
-    LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"

      xen_libs="-lxenstore -lxenctrl -lxenguest"
Anthony PERARD

Reviewed-by: Peter Maydell <address@hidden>

Cc'ing MJT, who first pointed out to me that this bug
was resulting in various binaries like the linux-user ones
getting linked against the Xen libs unnecessarily.

Well, at that time I confirmed the patch fixes this issue, and this
is the same change I come across too, and it is already used on Debian.

Signed-off-by: Michael Tokarev <address@hidden>
Revieved-by: Michael Tokarev <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]