[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v3 7/8] keymap: pass full keyboard state to keys
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [RFC PATCH v3 7/8] keymap: pass full keyboard state to keysym2scancode |
Date: |
Tue, 22 Jan 2019 10:28:13 +0100 |
Pass the keyboard state tracker handle down to keysym2scancode(),
so the code can fully inspect the keyboard state as needed. No
functional change.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
---
ui/keymaps.h | 3 ++-
ui/curses.c | 2 +-
ui/keymaps.c | 8 ++++----
ui/vnc.c | 5 +----
4 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/ui/keymaps.h b/ui/keymaps.h
index 4e9c87fb8f..d8652b8a5a 100644
--- a/ui/keymaps.h
+++ b/ui/keymaps.h
@@ -26,6 +26,7 @@
#define QEMU_KEYMAPS_H
#include "qemu-common.h"
+#include "ui/kbd-state.h"
typedef struct {
const char* name;
@@ -55,7 +56,7 @@ typedef struct kbd_layout_t kbd_layout_t;
kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,
const char *language, Error **errp);
int keysym2scancode(kbd_layout_t *k, int keysym,
- bool shift, bool altgr, bool ctrl);
+ QKbdState *kbd);
int keycode_is_keypad(kbd_layout_t *k, int keycode);
int keysym_is_numlock(kbd_layout_t *k, int keysym);
diff --git a/ui/curses.c b/ui/curses.c
index f4e7a12f74..54687589d4 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -273,7 +273,7 @@ static void curses_refresh(DisplayChangeListener *dcl)
}
keycode = keysym2scancode(kbd_layout, keysym & KEYSYM_MASK,
- false, false, false);
+ NULL);
if (keycode == 0)
continue;
diff --git a/ui/keymaps.c b/ui/keymaps.c
index 6e44f738ed..c8b2135340 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -188,7 +188,7 @@ kbd_layout_t *init_keyboard_layout(const name2keysym_t
*table,
int keysym2scancode(kbd_layout_t *k, int keysym,
- bool shift, bool altgr, bool ctrl)
+ QKbdState *kbd)
{
static const uint32_t mask =
SCANCODE_SHIFT | SCANCODE_ALTGR | SCANCODE_CTRL;
@@ -220,13 +220,13 @@ int keysym2scancode(kbd_layout_t *k, int keysym,
* If so, prefer that one.
*/
mods = 0;
- if (shift) {
+ if (kbd && qkbd_state_modifier_get(kbd, QKBD_MOD_SHIFT)) {
mods |= SCANCODE_SHIFT;
}
- if (altgr) {
+ if (kbd && qkbd_state_modifier_get(kbd, QKBD_MOD_ALTGR)) {
mods |= SCANCODE_ALTGR;
}
- if (ctrl) {
+ if (kbd && qkbd_state_modifier_get(kbd, QKBD_MOD_CTRL)) {
mods |= SCANCODE_CTRL;
}
diff --git a/ui/vnc.c b/ui/vnc.c
index a9fe166ee8..fc41f9b318 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1954,9 +1954,6 @@ static const char *code2name(int keycode)
static void key_event(VncState *vs, int down, uint32_t sym)
{
- bool shift = qkbd_state_modifier_get(vs->vd->kbd, QKBD_MOD_SHIFT);
- bool altgr = qkbd_state_modifier_get(vs->vd->kbd, QKBD_MOD_ALTGR);
- bool ctrl = qkbd_state_modifier_get(vs->vd->kbd, QKBD_MOD_CTRL);
int keycode;
int lsym = sym;
@@ -1965,7 +1962,7 @@ static void key_event(VncState *vs, int down, uint32_t
sym)
}
keycode = keysym2scancode(vs->vd->kbd_layout, lsym & 0xFFFF,
- shift, altgr, ctrl) & SCANCODE_KEYMASK;
+ vs->vd->kbd) & SCANCODE_KEYMASK;
trace_vnc_key_event_map(down, sym, keycode, code2name(keycode));
do_key_event(vs, down, keycode, sym);
}
--
2.9.3
- [Qemu-devel] [RFC PATCH v3 0/8] ui: add generic keyboard state tracker, fix keymap, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 5/8] kbd-state: use state tracker for gtk, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 2/8] sdl2: remove sdl2_reset_keys() function, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 7/8] keymap: pass full keyboard state to keysym2scancode,
Gerd Hoffmann <=
- [Qemu-devel] [RFC PATCH v3 8/8] keymap: fix keyup mappings, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 6/8] kbd-state: use state tracker for vnc, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 3/8] kbd-state: use state tracker for sdl2, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 1/8] kbd-state: add keyboard state tracker, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 4/8] sdl2: use only QKeyCode in sdl2_process_key(), Gerd Hoffmann, 2019/01/22