[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qem
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() |
Date: |
Tue, 22 Jan 2019 13:47:08 -0500 |
On Tue, Jan 22, 2019 at 09:33:37AM -0800, Dan Williams wrote:
> On Mon, Jan 21, 2019 at 7:27 PM Michael S. Tsirkin <address@hidden> wrote:
> [..]
> > > 2. The reset of cases:
> > > - we will never pass the MAP_SYNC to mmap2
> >
> > I don't see code probing for MAP_SYNC support. Did I miss it?
> > But if all you want is to have old linux ignore MAP_SYNC,
> > I think you got your wish automatically - just do not set
> > MAP_SHARED_VALIDATE.
>
> That will also cause new Linux to ignore MAP_SYNC.
Oh you are right. I missed this point.
And given that these patches do not seem to set MAP_SHARED_VALIDATE
at all I conclude that even though thet set MAP_SYNC
it actually has no effect at all.
So I wonder how they were tested.
Would the contributors care to elaborate?
That would be good info to put in the commit log message.
--
MST
- Re: [Qemu-devel] [PATCH V9 6/6] docs: Added MAP_SYNC documentation, (continued)
[Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Zhang Yi, 2019/01/16
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Michael S. Tsirkin, 2019/01/16
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Eduardo Habkost, 2019/01/18
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Yi Zhang, 2019/01/21
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Eduardo Habkost, 2019/01/21
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Yi Zhang, 2019/01/21
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Michael S. Tsirkin, 2019/01/21
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(), Dan Williams, 2019/01/22
- Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap(),
Michael S. Tsirkin <=
[Qemu-devel] [PATCH V9 5/6] hostmem: add more information in error messages, Zhang Yi, 2019/01/16