[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/2] s390x/pci: PCI bridge plugging fixes
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/2] s390x/pci: PCI bridge plugging fixes |
Date: |
Tue, 22 Jan 2019 14:01:10 +0100 |
On Tue, 22 Jan 2019 13:51:31 +0100
David Hildenbrand <address@hidden> wrote:
> Hotplugging of PCI bridges is right now pretty much broken. Coldplugging
> and hotplugging will assign wrong primary bus numbers in some scenarios.
>
> I base my knowledge on how this is supposed to work on
> http://www.science.unitn.it/~fiorella/guidelinux/tlk/node76.html
>
> I did a couple of tests, building whole hierarchies of bridges, both
> hot and coldplugged. "info pci" as well as the Linux guests showed
> what I was expecting.
>
> David Hildenbrand (2):
> s390x/pci: Fix primary bus number for PCI bridges
> s390x/pci: Fix hotplugging of PCI bridges
>
> hw/s390x/s390-pci-bus.c | 41 +++++++++++++++++++++++++++--------------
> 1 file changed, 27 insertions(+), 14 deletions(-)
>
I'll leave the actual review of this to folks familiar with how zPCI is
supposed to work :)
Does the guest actually see anything of this? Consistency is good, and
not crashing even better, but I think all of the topology is invisible
on the guest side anyway...
Re: [Qemu-devel] [PATCH v1 0/2] s390x/pci: PCI bridge plugging fixes,
Cornelia Huck <=
Re: [Qemu-devel] [PATCH v1 0/2] s390x/pci: PCI bridge plugging fixes, Cornelia Huck, 2019/01/28