[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branch
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branches |
Date: |
Tue, 22 Jan 2019 15:28:33 +0000 |
On Thu, 10 Jan 2019 at 12:18, Richard Henderson
<address@hidden> wrote:
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/translate-a64.c | 37 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 36 insertions(+), 1 deletion(-)
> {
> @@ -1985,6 +1998,7 @@ static void disas_exc(DisasContext *s, uint32_t insn)
> static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
> {
> unsigned int opc, op2, op3, rn, op4;
> + unsigned btype_mod = 2;
maybe add a comment /* 0: BR; 1: BLR; 2: other */
as otherwise you don't get to find out what the meaning of this
is until you get down to the end of the function.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 03/11] target/arm: Add BT and BTYPE to tb->flags, (continued)
- [Qemu-devel] [PATCH 04/11] target/arm: Record the GP bit for a page in MemTxAttrs, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 05/11] target/arm: Default handling of BTYPE during translation, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 06/11] target/arm: Reset btype for direct branches and syscalls, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branches, Richard Henderson, 2019/01/10
- Re: [Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branches,
Peter Maydell <=
- [Qemu-devel] [PATCH 08/11] target/arm: Add guarded_pages cpu property for user-only, Richard Henderson, 2019/01/10
[Qemu-devel] [PATCH 09/11] target/arm: Enable BTI for -cpu max, Richard Henderson, 2019/01/10
[Qemu-devel] [PATCH 10/11] linux-user/aarch64: Reset btype for signal handlers, Richard Henderson, 2019/01/10
[Qemu-devel] [PATCH 11/11] tests/tcg/aarch64: Add bti smoke test, Richard Henderson, 2019/01/10