[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler |
Date: |
Wed, 23 Jan 2019 15:58:27 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
Unregister the fd handler before we destroy the channel,
otherwise we've got a race where we might land in the
fd handler just as we're closing the device.
(The race is quite data dependent, you just have to have
the right set of devices for it to trigger).
Corresponds to RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1666601
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index 9b2e7e10aa..54a3c11540 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2321,6 +2321,7 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
rdma->connected = false;
}
+ qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
g_free(rdma->dest_blocks);
rdma->dest_blocks = NULL;
--
2.20.1
- [Qemu-devel] [PULL 0/9] migration queue, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 1/9] Fix segmentation fault when qemu_signal_init fails, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 2/9] migration: fix the multifd code when receiving less channels, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, simplify, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 4/9] migration: add more error handling for postcopy_ram_enable_notify, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 5/9] migration: unify error handling for process_incoming_migration_co, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 7/9] tests: add /vmstate/simple/array, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 8/9] vmstate: constify SaveVMHandlers, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 9/9] migration: introduce pages-per-second, Dr. David Alan Gilbert (git), 2019/01/23
- Re: [Qemu-devel] [PULL 0/9] migration queue, Peter Maydell, 2019/01/24