[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler

From: Dr. David Alan Gilbert (git)
Subject: [Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler
Date: Wed, 23 Jan 2019 15:58:27 +0000

From: "Dr. David Alan Gilbert" <address@hidden>

Unregister the fd handler before we destroy the channel,
otherwise we've got a race where we might land in the
fd handler just as we're closing the device.

(The race is quite data dependent, you just have to have
the right set of devices for it to trigger).

Corresponds to RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1666601

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
 migration/rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 9b2e7e10aa..54a3c11540 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2321,6 +2321,7 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
         rdma->connected = false;
+    qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
     rdma->dest_blocks = NULL;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]