[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source |
Date: |
Thu, 24 Jan 2019 12:43:05 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
> Move the complexity of milkymist_tmu2_create() into the
> source file. Doing so we avoid to include the X11/OpenGL
> headers in all LM32 devices, and we also avoid the duplicate
> declaration of glx_fbconfig_attr[] (it is already declared
> in hw/display/milkymist-tmu2.c).
> Since TYPE_MILKYMIST_TMU2 is now accessible, use it.
Oops, fails the build:
LINK lm32-softmmu/qemu-system-lm32
hw/lm32/milkymist.o: In function `milkymist_init':
milkymist.c:(.text+0xb0f): undefined reference to `milkymist_tmu2_create'
cheers,
Gerd
- [Qemu-devel] [PATCH v2 0/4] sdl: Let it be optional (in particular, on OpenBSD), Philippe Mathieu-Daudé, 2019/01/23
- [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/23
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/24
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Peter Maydell, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Paolo Bonzini, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Peter Maydell, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Thomas Huth, 2019/01/29