Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU

[Christophe Fergeau]

Hey,

On Thu, Jan 24, 2019 at 10:38:37AM +0100, Markus Armbruster wrote:
> Christophe Fergeau <address@hidden> writes:
> 
> > This commit adds a qemu_init_logging() helper which calls
> > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...)
> > are handled similarly to other QEMU logs. This means they will get a
> > timestamp if timestamps are enabled, and they will go through the
> > monitor if one is configured.
> > This commit also adds a call to qemu_init_logging() to the binaries
> > installed by QEMU.
> > glib debug messages are enabled through G_MESSAGES_DEBUG similarly to
> > glib default log handler.
> >
> > At the moment, this change will mostly impact SPICE logging if your
> > spice version is >= 0.14.1. With older spice versions, this is not going
> > to work as expected, but will not have any ill effect, so this call is
> > not conditional on the SPICE version.
> >
> > Signed-off-by: Christophe Fergeau <address@hidden>
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> 
> Do you expect this to go through my tree?

To be honest, I don't know through whose tree this should go.

> Hint: if you do, cc'ing me tends to help ;)
> 
> scripts/get_maintainer.pl can be your friend.

I ran it, but it returned a few too many names given that it touches
files in various subsystems, I was not sure I should cc: everyone.
Now that I look again, at least "(supporter:Error reporting)" would have
made sense.

Thanks for noticing this patch without the cc: :)

Christophe

signature.asc
Description: PGP signature