[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating |
Date: |
Thu, 24 Jan 2019 19:29:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 1/24/19 3:35 AM, Markus Armbruster wrote:
>
>> To gauge the bug's impact, let's review non-interpolating users of this
>> parser, i.e. code passing NULL context to json_message_parser_init():
>>
>> * tests/check-qjson.c, tests/test-qobject-input-visitor.c,
>> tests/test-visitor-serialization.c
>>
>> Plenty of tests, but we still failed to cover the buggy case.
>>
>> * monitor.c: QMP input
>>
>> * qga/main.c: QGA input
>>
>> * qobject_from_json():
>>
>> - qobject-input-visitor.c: JSON command line option arguments of
>> -display and -blockdev
>>
>> Reproducer: -blockdev '{"%"}'
>>
>> - block.c: JSON pseudo-filenames starting with "json:"
>>
>> Reproducer: https://bugzilla.redhat.com/show_bug.cgi?id=1668244#c3
>>
>> - block/rbd.c: JSON key pairs
>>
>> Pseudo-filenames starting with "rbd:".
>>
>
> Missed curl as being impacted. You'd have to do a v2 pull request to
> mention it now...
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1668244
Isn't that an instance of 'JSON pseudo-filenames starting with "json:"'?
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, (continued)
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Daniel P . Berrangé, 2019/01/09
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Max Reitz, 2019/01/09
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Daniel P . Berrangé, 2019/01/09
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Markus Armbruster, 2019/01/10
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Richard W.M. Jones, 2019/01/22
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Markus Armbruster, 2019/01/24
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Christophe Fergeau, 2019/01/24
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Eric Blake, 2019/01/24
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Eric Blake, 2019/01/24
Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Richard W.M. Jones, 2019/01/22
Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating, Markus Armbruster, 2019/01/24