[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage

From: Zoltán Kővágó
Subject: Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage
Date: Thu, 24 Jan 2019 21:12:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-24 12:19, Gerd Hoffmann wrote:
>   Hi,
>> So, I think with the first part the only open issue is whenever we go
>> with the nested types (i.e. patch #1 as-is) or not.  Given that the
>> one-element-structs added in that patch will get additional fields I
>> think the nesting makes sense.
> Spoke too soon: scripts/checkpatch.pl flags a bunch of codestyle issues.

Most of them are about the code style of the old audio subsystem, I
fixed some of them but not everything.  IIRC last time it wasn't a
problem, but it was in 2015.  Should I go over them again and fix all of


reply via email to

[Prev in Thread] Current Thread [Next in Thread]