Re: [Qemu-devel] [PATCH 2/2] aspeed/scu: Implement power off register

[Joel Stanley]

On Fri, 4 Jan 2019 at 03:26, Peter Maydell <address@hidden> wrote:
>
> On Tue, 11 Dec 2018 at 03:11, Joel Stanley <address@hidden> wrote:
> >
> > This register does not exist in hardware. It is here to allow the guest
> > code to cause Qemu to exit when required.
> >
> > The register address chosen is unused in the emulated machines
> > datasheets.

> I'm always a bit dubious about adding things to QEMU devices
> which don't exist in the real hardware we're emulating. If we
> do want to do that, I think we should clearly flag them up as
> being QEMU-specific with suitable comments and naming of
> the #define, etc.

Since writing this patch I was made aware of -no-reboot. That flag
solves the problem I had so we can drop these patches for now.

Cheers,

Joel