[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1795100] Re: VNC unix-domain socket unlink()ed prematu
[Qemu-devel] [Bug 1795100] Re: VNC unix-domain socket unlink()ed prematurely
Fri, 25 Jan 2019 09:59:35 -0000
Fix merged to git master
** Changed in: qemu
Status: New => Fix Committed
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
VNC unix-domain socket unlink()ed prematurely
Status in QEMU:
With qemu 3.0.0 (I don't believe this happened with previous
versions), if I tell it `-vnc unix:/path/to/vnc.sock`, qemu will
unlink() that file when the first client disconnects, meaning that
once I disconnect, I can't ever reconnect without restarting the VM.
A stupid testcase demonstrating the issue:
In terminal A:
$ qemu-system-x86_64 -vnc unix:$PWD/vnc.sock
In terminal B:
$ ls vnc.sock
$ socat STDIO UNIX-CONNECT:vnc.sock <<<''
$ ls vnc.sock
ls: cannot access 'vnc.sock': No such file or directory
I have determined that the offending unlink() call is the one in
io/channel-socket.c:qio_channel_socket_close(). That call was first
introduced in commit d66f78e1eaa832f73c771d9df1b606fe75d52a50, which
first appeared in version 3.0.0.
This type of premature unlink() does not happen on monitor.sock with
I am not familiar enough with the QIO subsystem to suggest a fix that
fixes VNC, but preserves the QMP fix targeted in the offending commit.
To manage notifications about this bug go to: