[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separ

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separate file
Date: Fri, 25 Jan 2019 16:22:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 25/01/19 15:53, Thomas Huth wrote:
> Since the ioport code clearly depends on ISA, I think you could also
> simply do:
> common-obj-$(CONFIG_ISA_BUS) += ioport.o
> instead of adding it to three different lines here?

No, because that would add the function even if !IDE && ISA_BUS, causing
undefined symbols from ide_ioport_read and friends.

> Well, the linker should be smart enough to deal with multiple entries,
> so it's likely just a matter of taste.

It's not the linker, rules.mak explicitly drops duplicates.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]