[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/52] hw/s390/Makefile.objs: Create new CONFIG_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 13/52] hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices |
Date: |
Fri, 25 Jan 2019 16:23:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 25/01/19 16:17, Thomas Huth wrote:
>> +ifeq ($(CONFIG_S390_CCW_VIRTIO),y)
>> obj-y += s390-virtio-hcall.o
>> obj-y += sclp.o
>> obj-y += event-facility.o
>> @@ -33,3 +34,4 @@ obj-$(CONFIG_KVM) += s390-stattrib-kvm.o
>> obj-y += s390-ccw.o
>> obj-y += ap-device.o
>> obj-y += ap-bridge.o
>> +endif
> That won't really work, a lot of code in target/s390x still depends on
> the functions in these files here. I suggest to just disable the file
> that defines the machine initially, i.e.:
>
> obj-$(CONFIG_S390_CCW_VIRTIO) += s390-virtio-ccw.o
>
> We can still fine-tune this later.
Ok, I'll leave this and the other changes you suggest to Yang for v6. :)
Paolo
- Re: [Qemu-devel] [PATCH 20/52] hw/alpha/Makefile.objs: Create CONFIG_* for alpha, (continued)
- [Qemu-devel] [PATCH 22/52] hw/hppa/Makefile.objs: Create CONFIG_* for hppa, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 16/52] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 12/52] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 11/52] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 30/52] minikconfig: add semantic analysis, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 13/52] hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 26/52] hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 29/52] minikconfig: add AST, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 28/52] minikconfig: add parser skeleton, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 33/52] build: switch to Kconfig, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 35/52] ide: express dependencies with Kconfig, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 34/52] minikconf: implement allnoconfig and defconfig, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 31/52] hw/display: make edid configurable, Paolo Bonzini, 2019/01/25