[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/52] hw/moxie/Makefile.objs: Conditionally bui
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 23/52] hw/moxie/Makefile.objs: Conditionally build moxie |
Date: |
Fri, 25 Jan 2019 16:33:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-25 11:06, Paolo Bonzini wrote:
> From: Yang Zhong <address@hidden>
>
> CONFIG_MOXIE added for moxiesim board.
>
> Signed-off-by: Yang Zhong <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> default-configs/moxie-softmmu.mak | 1 +
> hw/moxie/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/moxie-softmmu.mak
> b/default-configs/moxie-softmmu.mak
> index e00d099..b176563 100644
> --- a/default-configs/moxie-softmmu.mak
> +++ b/default-configs/moxie-softmmu.mak
> @@ -5,3 +5,4 @@ CONFIG_MC146818RTC=y
> CONFIG_SERIAL=y
> CONFIG_SERIAL_ISA=y
> CONFIG_VGA=y
> +CONFIG_MOXIE=y
> diff --git a/hw/moxie/Makefile.objs b/hw/moxie/Makefile.objs
> index bfc9001..cb575ef 100644
> --- a/hw/moxie/Makefile.objs
> +++ b/hw/moxie/Makefile.objs
> @@ -1,2 +1,2 @@
> # moxie boards
> -obj-y += moxiesim.o
> +obj-$(CONFIG_MOXIE) += moxiesim.o
<bikeshedding>
Let's call it CONFIG_MOXIESIM - like the machine, not the CPU.
</bikeshedding>
Anyway:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 14/52] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created, (continued)
- [Qemu-devel] [PATCH 14/52] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 21/52] hw/cris/Makefile.objs: Create CONFIG_* for cris, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 19/52] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 18/52] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 17/52] hw/nios2/Makefile.objs: Conditionally build nios2, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 24/52] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 15/52] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 23/52] hw/moxie/Makefile.objs: Conditionally build moxie, Paolo Bonzini, 2019/01/25
- Re: [Qemu-devel] [PATCH 23/52] hw/moxie/Makefile.objs: Conditionally build moxie,
Thomas Huth <=
- [Qemu-devel] [PATCH 25/52] hw/tricore/Makefile.objs: Create CONFIG_* for tricore, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 27/52] hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 20/52] hw/alpha/Makefile.objs: Create CONFIG_* for alpha, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 22/52] hw/hppa/Makefile.objs: Create CONFIG_* for hppa, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 16/52] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 12/52] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 11/52] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*, Paolo Bonzini, 2019/01/25