[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] cmd646: Remove unused variable
From: |
John Snow |
Subject: |
[Qemu-devel] [PULL 1/8] cmd646: Remove unused variable |
Date: |
Fri, 25 Jan 2019 17:06:41 -0500 |
From: BALATON Zoltan <address@hidden>
There was a pointer to PCIIDEState in CMD646BAR which was set but
not used afterwards. Get rid of this unused variable.
Signed-off-by: BALATON Zoltan <address@hidden>
Tested-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
hw/ide/cmd646.c | 1 -
include/hw/ide/pci.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 6bb92d717f..41c1831f9a 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -123,7 +123,6 @@ static void setup_cmd646_bar(PCIIDEState *d, int bus_num)
CMD646BAR *bar = &d->cmd646_bar[bus_num];
bar->bus = bus;
- bar->pci_dev = d;
memory_region_init_io(&bar->cmd, OBJECT(d), &cmd646_cmd_ops, bar,
"cmd646-cmd", 4);
memory_region_init_io(&bar->data, OBJECT(d), &cmd646_data_ops, bar,
diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h
index dbc6a0383d..ed723acfb4 100644
--- a/include/hw/ide/pci.h
+++ b/include/hw/ide/pci.h
@@ -41,7 +41,6 @@ typedef struct CMD646BAR {
MemoryRegion cmd;
MemoryRegion data;
IDEBus *bus;
- struct PCIIDEState *pci_dev;
} CMD646BAR;
#define TYPE_PCI_IDE "pci-ide"
--
2.17.2
- [Qemu-devel] [PULL 0/8] Ide patches, John Snow, 2019/01/25
- [Qemu-devel] [PULL 1/8] cmd646: Remove unused variable,
John Snow <=
- [Qemu-devel] [PULL 4/8] ide: Get rid of CMD646BAR struct, John Snow, 2019/01/25
- [Qemu-devel] [PULL 3/8] cmd646: Move PCI IDE specific functions to ide/pci.c, John Snow, 2019/01/25
- [Qemu-devel] [PULL 7/8] ide/via: Rename functions to match device name, John Snow, 2019/01/25
- [Qemu-devel] [PULL 8/8] ide/via: Implement and use native PCI IDE mode, John Snow, 2019/01/25
- [Qemu-devel] [PULL 6/8] ide/via: Remove vt82c686b_init_ports() function, John Snow, 2019/01/25
- [Qemu-devel] [PULL 5/8] sii3112: Remove duplicated code and use PCI IDE ops instead, John Snow, 2019/01/25
- [Qemu-devel] [PULL 2/8] cmd646: Remove IDEBus from CMD646BAR, John Snow, 2019/01/25
- Re: [Qemu-devel] [PULL 0/8] Ide patches, Peter Maydell, 2019/01/28