[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/9] Extend the command-line to provide memor

From: Tao Xu
Subject: Re: [Qemu-devel] [PATCH v2 4/9] Extend the command-line to provide memory latency and bandwidth information
Date: Mon, 28 Jan 2019 17:42:54 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/22/2019 1:09 AM, Eric Blake wrote:
On 1/21/19 12:03 AM, Tao Xu wrote:

+# @hmat-lb: memory latency and bandwidth information (Since: 2.13)
s/2.13/4.0/ (probably in multiple spots in your series)
Hi Eric,

Thank you for your comments. The spell mistakes in patches 1/9 to 6/9
have been corrected in patch 7/9. Because patches 1/9 to 6/9 are jingqi's
initial V1 patchesand7/9 to 9/9 are the changes compared withV1.

Still, it's better to rebase the series to avoid the mistakes in the
first place, instead of having churn with a mistake early in the series
corrected only later in the series.  Even if the mistake is corrected by
a different author than the bulk of the patch, as long as there are
Signed-off-by lines for both the original author and the person making
the spelling correction, then proper attribution has been made.

About s/2.13/4.0/,do you mean ACPI HMAT will not be merged before QEMU

Correct - 4.0 is the next release planned.  There was no 2.13 release;
after 2.12 was the 3.0 release; the current release is 3.1, and the next
release is 4.0; for more details, see
https://www.qemu.org/2018/08/15/qemu-3-0-0/ for a description of the
current version numbering scheme.  And even making it in time for 4.0
means polishing this by mid-March: https://wiki.qemu.org/Planning/4.0

In addition, do you have any other comments about these patches?

I was commenting on the high-level user interface issues, but will leave
the bulk of the technical review to those more familiar with the code
being added.

Hi Eric, I am sorry for asking you so frequently and don't mean to rush you. Could you tell me when I can know this comments on the high-level user interface issues? So that I can improve my patch in the next version. Thank you and looking forward to your reply!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]