qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null",


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure
Date: Mon, 28 Jan 2019 12:03:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 28/01/19 10:47, Alex Bennée wrote:
>>
>> [1] The fix seems https://github.com/openbsd/src/commit/c2a35b387f9d3c
>>   "fcntl(F_SETFL) invokes the FIONBIO and FIOASYNC ioctls internally, so
>>   the memory devices (/dev/null, /dev/zero, etc) need to permit them."
> I assume set_nonblock is called on more than just these special devices?
> Is there anyway to check this on OpenBSD or is it just an anonymous fd
> at this point?
> 

Perhaps on OpenBSD we should just assert that we don't get EBADF?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]