[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT |
|
Date: |
Mon, 28 Jan 2019 11:07:32 +0000 |
|
User-agent: |
mu4e 1.1.0; emacs 26.1.91 |
Samuel Thibault <address@hidden> writes:
> Alex Bennée, le lun. 28 janv. 2019 10:35:37 +0000, a ecrit:
>> Samuel Thibault <address@hidden> writes:
>>
>> > Signed-off-by: Samuel Thibault <address@hidden>
>>
>> Is there a rationale as to why we should replace QEMU_BUILD_BUG_ON with
>> G_STATIC_ASSERT or is it particular to these QEMU_BUILD_BUG_ON
>> instances? It would be nice to have a little more context in the commit
>> message.
>
> It is yet more work towards moving slirp/ to a separately-maintained
> libslirp.
thanks, that makes more sense. If you could just mention that in the
commit it would save confusion about QEMU_BUILD_BUG_ON being deprecated
;-)
With that:
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée