[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/19] boards.h: Ignore migration for SMBus d
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/19] boards.h: Ignore migration for SMBus devices on older machines |
Date: |
Mon, 28 Jan 2019 16:08:59 -0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Jan 28, 2019 at 11:54:49AM -0600, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Migration capability is being added for pm_smbus and SMBus devices.
> This change will allow backwards compatibility to be kept when
> migrating back to an old qemu version. Add a bool to the machine
> class tho keep smbus migration from happening. Future changes
> will use this.
>
> Signed-off-by: Corey Minyard <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/i386/pc_piix.c | 1 +
> hw/i386/pc_q35.c | 1 +
> include/hw/boards.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 6ba163ccbb..a8331b82f2 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -431,6 +431,7 @@ static void pc_i440fx_machine_options(MachineClass *m)
> static void pc_i440fx_4_0_machine_options(MachineClass *m)
> {
> pc_i440fx_machine_options(m);
> + m->smbus_no_migration_support = true;
> m->alias = "pc";
> m->is_default = 1;
> }
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 1689885cac..bafc73b2d9 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -368,6 +368,7 @@ static void pc_q35_machine_options(MachineClass *m)
> static void pc_q35_4_0_machine_options(MachineClass *m)
> {
> pc_q35_machine_options(m);
> + m->smbus_no_migration_support = true;
> m->alias = "q35";
> }
>
Wasn't this supposed to be added to pc_*_3_1_machine_options(),
so the flag is set to false on pc-*-4.0?
--
Eduardo
- [Qemu-devel] [PATCH v4 00/19] Fix/add vmstate handling in some I2C code, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 19/19] i2c: Verify that the count passed in to smbus_eeprom_init() is valid, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 16/19] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 14/19] i2c:smbus_slave: Add an SMBus vmstate structure, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 10/19] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2019/01/28
- Re: [Qemu-devel] [PATCH v4 10/19] boards.h: Ignore migration for SMBus devices on older machines,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v4 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 02/19] i2c: have I2C receive operation return uint8_t, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 05/19] i2c:smbus: Correct the working of quick commands, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 11/19] i2c:pm_smbus: Fix pm_smbus handling of I2C block read, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 04/19] i2c: Don't check return value from i2c_recv(), minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 03/19] arm:i2c: Don't mask return from i2c_recv(), minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 17/19] i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 08/19] i2c:smbus_eeprom: Get rid of the quick command, minyard, 2019/01/28
- [Qemu-devel] [PATCH v4 13/19] i2c:pm_smbus: Fix state transfer, minyard, 2019/01/28