Re: [Qemu-devel] [PATCH v8 2/2] qemu-img info: bitmaps extension new test 239

[Eric Blake]

On 1/28/19 12:40 PM, Andrey Shinkevich wrote:
> A new test file 239 added to the qemu-iotests set. It checks
> the output format of 'qemu-img info' for bitmaps extension of
> qcow2 specific information.
> 
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---

> +++ b/tests/qemu-iotests/239.out
> @@ -0,0 +1,33 @@
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 16384, 
> "name": "bitmap-1", "node": "drive0", "persistent": true}}
> +{"return": {}}
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 32768, 
> "name": "bitmap-2", "node": "drive0", "persistent": true}}
> +{"return": {}}
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 65536, 
> "name": "bitmap-3", "node": "drive0", "persistent": true}}

Should the test also create a disabled bitmap ("enabled":false), to show
the change in flags, and/or a non-persistent bitmap (to show that it
does not affect the qcow2 information, but only the query-blocks output,
because it is transient)?



-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature