[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() |
Date: |
Tue, 29 Jan 2019 09:25:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/29/19 1:08 AM, Wei Yang wrote:
> Function pc_acpi_init() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc.c | 27 ---------------------------
> include/hw/i386/pc.h | 1 -
> 2 files changed, 28 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5317e08f60..734d3268fa 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner,
> MemoryRegion *system_memory,
> pci_address_space, -1);
> }
>
> -void pc_acpi_init(const char *default_dsdt)
> -{
> - char *filename;
> -
> - if (acpi_tables != NULL) {
> - /* manually set via -acpitable, leave it alone */
> - return;
> - }
> -
> - filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
> - if (filename == NULL) {
> - warn_report("failed to find %s", default_dsdt);
> - } else {
> - QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
> - &error_abort);
> - Error *err = NULL;
> -
> - qemu_opt_set(opts, "file", filename, &error_abort);
> -
> - acpi_table_add_builtin(opts, &err);
> - if (err) {
> - warn_reportf_err(err, "failed to load %s: ", filename);
> - }
> - g_free(filename);
> - }
> -}
> -
> void xen_load_linux(PCMachineState *pcms)
> {
> int i;
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9d29c4b1df..541124ba6d 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int
> level);
>
> void pc_cpus_init(PCMachineState *pcms);
> void pc_hot_add_cpu(const int64_t id, Error **errp);
> -void pc_acpi_init(const char *default_dsdt);
>
> void pc_guest_info_init(PCMachineState *pcms);
>
>
- [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(), Wei Yang, 2019/01/25
- [Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin, Wei Yang, 2019/01/25
- [Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin(), Wei Yang, 2019/01/25
- Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(), Igor Mammedov, 2019/01/28
- [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/28
- [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin, Wei Yang, 2019/01/28
- [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(), Wei Yang, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(),
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin(), Wei Yang, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Philippe Mathieu-Daudé, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Philippe Mathieu-Daudé, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Michael S. Tsirkin, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29