[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest |
Date: |
Tue, 29 Jan 2019 10:11:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 29/01/2019 09:38, Philippe Mathieu-Daudé wrote:
> Due to a misuse of rules.mak logical functions, commit f386df17448
> disabled the guest-agent test.
> Enable it back.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> From rules.mak:
>
> # Logical functions (for operating on y/n values like CONFIG_FOO vars)
> # Usage: $(call land,$(CONFIG_FOO),$(CONFIG_BAR))
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 19b4c0a696..172128b058 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -110,7 +110,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
> ifneq (,$(findstring qemu-ga,$(TOOLS)))
> -check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) +=
> tests/test-qga$(EXESUF)
> +check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) +=
> tests/test-qga$(EXESUF)
> endif
> check-unit-y += tests/test-timed-average$(EXESUF)
> check-unit-y += tests/test-util-sockets$(EXESUF)
>
Reviewed-by: Laurent Vivier <address@hidden>