[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat |
Date: |
Tue, 29 Jan 2019 10:43:13 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Ping.
On 7/8/18 6:49 PM, Richard Henderson wrote:
> The error indicator for this syscall is -1, not 0.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tests/tcg/multiarch/linux-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/linux-test.c
> b/tests/tcg/multiarch/linux-test.c
> index e80eccc0ce..6d2c02c5c0 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -503,8 +503,9 @@ static void test_shm(void)
>
> shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
> ptr = shmat(shmid, NULL, 0);
> - if (!ptr)
> + if (ptr == (void *)-1) {
> error("shmat");
> + }
>
> memset(ptr, 0, SHM_SIZE);
>
>
- Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat,
Richard Henderson <=