[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR)

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR)
Date: Tue, 29 Jan 2019 15:09:44 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/29/19 5:39 AM, Daniel P. Berrangé wrote:
> This breaks when $(prefix) is a relative directory, as it turns it
> into an absolute path.
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
>  Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Yes, it is long-standing practice among Automake and others that
$(DESTDIR) is normally empty but should contain its own trailing slash
when defined, as it is NOT separated from the rest of the installation
lines with an explicit /.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]