Re: [Qemu-devel] [PATCH 5/9] iotests: Fix 237 for Python 2.x

[John Snow]

On 1/23/19 9:46 AM, Max Reitz wrote:
> It is not quite clear whether we want to support Python 2.x for any
> prolonged time, but this may as well be fixed along with the other
> issues some iotests have right now.
> 

I'd have shuffled this above patch 01 (or immediately below) with a note
in either commit saying that the test is still broken without both patches.

I'd also say what you're actually fixing in the commit
(range wants ints, not floats.)

> Signed-off-by: Max Reitz <address@hidden>

But, like, that's just my opinion, man,,

Reviewed-by: John Snow <address@hidden>

> ---
>  tests/qemu-iotests/237 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/237 b/tests/qemu-iotests/237
> index fe0dd0f461..06897f8c87 100755
> --- a/tests/qemu-iotests/237
> +++ b/tests/qemu-iotests/237
> @@ -224,7 +224,7 @@ with iotests.FilePath('t.vmdk') as disk_path, \
>              iotests.log("= %s %d =" % (subfmt, size))
>              iotests.log("")
>  
> -            num_extents = math.ceil(size / 2.0**31)
> +            num_extents = int(math.ceil(size / 2.0**31))
>              extents = [ "ext%d" % (i) for i in range(1, num_extents + 1) ]
>  
>              vm.launch()
>