qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS


From: John Snow
Subject: Re: [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS
Date: Tue, 29 Jan 2019 16:26:21 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0


On 1/23/19 9:46 AM, Max Reitz wrote:
> With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests
> the file-posix protocol driver).  Therefore, if $TEST_IMG_FILE is set,
> use that instead.
> 
> Because this test requires the file protocol, $TEST_IMG_FILE will always
> be set if $IMGOPTSSYNTAX is true.
> 
> Signed-off-by: Max Reitz <address@hidden>

This keeps biting us. Or at least, it bit me once and then it has bitten
someone else. It's not obvious that you need to accommodate this when
writing a new test.

For now, anyway, this does give us a new bandaid for a while longer.

Reviewed-by: John Snow <address@hidden>

> ---
>  tests/qemu-iotests/232 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232
> index 93e5d641a3..e48bc8f5db 100755
> --- a/tests/qemu-iotests/232
> +++ b/tests/qemu-iotests/232
> @@ -69,6 +69,10 @@ size=128M
>  
>  _make_test_img $size
>  
> +if [ -n "$TEST_IMG_FILE" ]; then
> +    TEST_IMG=$TEST_IMG_FILE
> +fi
> +
>  echo
>  echo "=== -drive with read-write image: read-only/auto-read-only 
> combinations ==="
>  echo
> 

-- 
—js



reply via email to

[Prev in Thread] Current Thread [Next in Thread]