qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional o


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD
Date: Wed, 30 Jan 2019 08:52:52 +0100
User-agent: NeoMutt/20180716

  Hi,

>      sdl)
>      if test "$sdl" = "no"; then
> -        error_exit "sdl not found or disabled, can not use sdl audio driver"
> +        echo "WARNING: SDL not found or disabled, can not use sdl audio 
> driver"
> +        audio_drv_list=$(echo "$audio_drv_list" | sed -e 's/sdl *//g')

Not needed any more.

> +if test -z "$audio_drv_list"; then
> +    audio_drv_list="none"
> +fi

That puts "none" into the list of audio drivers.  I don't think we
should do that.  If you want prettify the output in case audio_drv_list
is empty, then just fix the output code.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]