[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional o
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD |
Date: |
Wed, 30 Jan 2019 08:52:52 +0100 |
User-agent: |
NeoMutt/20180716 |
Hi,
> sdl)
> if test "$sdl" = "no"; then
> - error_exit "sdl not found or disabled, can not use sdl audio driver"
> + echo "WARNING: SDL not found or disabled, can not use sdl audio
> driver"
> + audio_drv_list=$(echo "$audio_drv_list" | sed -e 's/sdl *//g')
Not needed any more.
> +if test -z "$audio_drv_list"; then
> + audio_drv_list="none"
> +fi
That puts "none" into the list of audio drivers. I don't think we
should do that. If you want prettify the output in case audio_drv_list
is empty, then just fix the output code.
cheers,
Gerd
- [Qemu-devel] [PATCH v3 0/5] sdl: Let it be optional (in particular, on OpenBSD), Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-devel] [PATCH v3 1/5] hw/lm32: Move LM32 specific hardware out of common-obj list, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-devel] [PATCH v3 2/5] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-devel] [PATCH v3 5/5] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-devel] [PATCH v3 3/5] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL, Philippe Mathieu-Daudé, 2019/01/29
- [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD, Philippe Mathieu-Daudé, 2019/01/29
- Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD,
Gerd Hoffmann <=