Re: [Qemu-devel] [PATCH 5/9] iotests: Fix 237 for Python 2.x

[Max Reitz]

On 29.01.19 22:21, John Snow wrote:
> 
> On 1/23/19 9:46 AM, Max Reitz wrote:
>> It is not quite clear whether we want to support Python 2.x for any
>> prolonged time, but this may as well be fixed along with the other
>> issues some iotests have right now.
>>
> 
> I'd have shuffled this above patch 01 (or immediately below) with a note
> in either commit saying that the test is still broken without both patches.

It's only broken for Python 2.x. :-)

I don't have any real order in this series, though, so whatever makes
someone happy makes me happy, too.

> I'd also say what you're actually fixing in the commit
> (range wants ints, not floats.)

Sure, I can add that.

>> Signed-off-by: Max Reitz <address@hidden>
> 
> But, like, that's just my opinion, man,,
> 
> Reviewed-by: John Snow <address@hidden>

Thanks!

Max

signature.asc
Description: OpenPGP digital signature