[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/5] hw/arm/boot: Clarify why arm_setup_firmware_boo
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 4/5] hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info |
Date: |
Thu, 31 Jan 2019 11:22:39 +0000 |
The code path for booting firmware doesn't set env->boot_info. At
first sight this looks odd, so add a comment saying why we don't.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/arm/boot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index a2e724ac68a..cfcfdf421cf 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -1186,7 +1186,8 @@ static void arm_setup_firmware_boot(ARMCPU *cpu, struct
arm_boot_info *info)
/*
* We will start from address 0 (typically a boot ROM image) in the
- * same way as hardware.
+ * same way as hardware. Leave env->boot_info NULL, so that
+ * do_cpu_reset() knows it does not need to alter the PC on reset.
*/
}
--
2.20.1
- [Qemu-devel] [PATCH 0/5] hw/arm/boot: Support DTB autoload for firmware-only boots, Peter Maydell, 2019/01/31
- [Qemu-devel] [PATCH 1/5] hw/arm/boot: Fix block comment style in arm_load_kernel(), Peter Maydell, 2019/01/31
- [Qemu-devel] [PATCH 2/5] hw/arm/boot: Factor out "direct kernel boot" code into its own function, Peter Maydell, 2019/01/31
- [Qemu-devel] [PATCH 3/5] hw/arm/boot: Factor out "set up firmware boot" code, Peter Maydell, 2019/01/31
- [Qemu-devel] [PATCH 5/5] hw/arm/boot: Support DTB autoload for firmware-only boots, Peter Maydell, 2019/01/31
- [Qemu-devel] [PATCH 4/5] hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/5] hw/arm/boot: Support DTB autoload for firmware-only boots, Richard Henderson, 2019/01/31