Re: [Qemu-devel] [PATCH 32/52] kconfig: introduce kconfig files

[Paolo Bonzini]

On 31/01/19 14:21, Thomas Huth wrote:
> On 2019-01-25 11:06, Paolo Bonzini wrote:
> [...]
>> diff --git a/hw/misc/macio/Kconfig b/hw/misc/macio/Kconfig
>> new file mode 100644
>> index 0000000..c6caeb6
>> --- /dev/null
>> +++ b/hw/misc/macio/Kconfig
>> @@ -0,0 +1,11 @@
>> +config CUDA
>> +    bool
>> +
>> +config MAC_PMU
>> +    bool
>> +
>> +config MAC_DBDMA
>> +    bool
>> +
>> +config MACIO_GPIO
>> +    bool
> [...]
>> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
>> new file mode 100644
>> index 0000000..9da9d7d
>> --- /dev/null
>> +++ b/hw/ppc/Kconfig
> [...]
>> +
>> +config MAC_DBDMA
>> +    bool
>> +
>> +config MAC_PMU
>> +    bool
>> +
>> +config XIVE
>> +    bool
>> +
>> +config MACIO_GPIO
>> +    bool
>> +
>> +config XIVE_SPAPR
>> +    bool
>> +
>> +config CUDA
>> +    bool
> 
> I just noticed that the config switches from hw/misc/macio/Kconfig are
> duplicated here. Kind of ugly. Would it be possible to define them only
> in one place?

Yes, of course.  It's also a good idea to detect duplicate "config"
directives.

Paolo