[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio: PCI proxy devices should depend on CONF
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio: PCI proxy devices should depend on CONFIG_VIRTIO_PCI |
|
Date: |
Thu, 31 Jan 2019 17:10:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-31 15:59, Paolo Bonzini wrote:
> ... otherwise, they break the build in the rare case where
> CONFIG_VIRTIO_PCI is disabled (which will not be so rare
> once kconfig goes in).
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/virtio/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs
> index ea7913d..d335dd0 100644
> --- a/hw/virtio/Makefile.objs
> +++ b/hw/virtio/Makefile.objs
> @@ -11,7 +11,7 @@ obj-$(call
> land,$(CONFIG_VIRTIO_CRYPTO),$(CONFIG_VIRTIO_PCI)) += virtio-crypto-p
>
> obj-$(CONFIG_LINUX) += vhost.o vhost-backend.o vhost-user.o
> obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o
> -ifeq ($(CONFIG_PCI),y)
> +ifeq ($(CONFIG_VIRTIO_PCI),y)
> obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock-pci.o
> obj-$(CONFIG_VHOST_USER_BLK) += vhost-user-blk-pci.o
> obj-$(CONFIG_VHOST_USER_SCSI) += vhost-user-scsi-pci.o
Miroslav hit this already, too:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06552.html
Thomas