Re: [Qemu-devel] [PATCH RFC 00/11] Add Renesas RX archtecture

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH RFC 00/11] Add Renesas RX archtecture
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a739c452f4 MAINTAINERS: Add RX entry.
3778b84308 Add rx-softmmu.
9b35f3e02a RX Target hardware definition.
d098f8610b RX62N internal serical communication interface.
d1fda562b0 RX62N internal timer unit.
58ae337613 RX62N interrupt contoller.
9cb21f3ffd RX disassembler
ce17708f0b Target miscellaneous functions.
276096a543 TCG helper functions
02c37e53dc RX CPU definition
228562c3da TCG translation

=== OUTPUT BEGIN ===
1/11 Checking commit 228562c3dabd (TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: space prohibited between function name and open parenthesis '('
#408: FILE: target/rx/op_helper.c:361:
+typedef float32 (*floatfunc)(float32 f1, float32 f2, float_status *st);

ERROR: spaces required around that '*' (ctx:WxV)
#408: FILE: target/rx/op_helper.c:361:
+typedef float32 (*floatfunc)(float32 f1, float32 f2, float_status *st);
                                                                   ^

total: 2 errors, 1 warnings, 3573 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/11 Checking commit 02c37e53dcae (RX CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 492 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 276096a543bc (TCG helper functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 143 lines checked

Patch 3/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit ce17708f0bed (Target miscellaneous functions.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 152 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit 9cb21f3ffddb (RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#1067: FILE: disas/rx.c:1038:
+#define prt(...) dis->fprintf_func(dis->stream, __VA_ARGS__)

ERROR: space prohibited between function name and open parenthesis '('
#1326: FILE: include/disas/bfd.h:439:
+int print_insn_rx               (bfd_vma, disassemble_info*);

total: 2 errors, 1 warnings, 1301 lines checked

Patch 5/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/11 Checking commit 58ae3376133f (RX62N interrupt contoller.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 366 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit d1fda562b065 (RX62N internal timer unit.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: return is not a function, parentheses are not required
#375: FILE: hw/timer/renesas_tmr.c:109:
+        return (tmr->tcnt[0] << 8) | (tmr->tcnt[1] & 0xff);

total: 1 errors, 1 warnings, 710 lines checked

Patch 7/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/11 Checking commit d098f8610bf1 (RX62N internal serical communication 
interface.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 329 lines checked

Patch 8/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/11 Checking commit 9b35f3e02a44 (RX Target hardware definition.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 392 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 3778b8430851 (Add rx-softmmu.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 44 lines checked

Patch 10/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/11 Checking commit a739c452f473 (MAINTAINERS: Add RX entry.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden