qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] pcie: Add simple ACS "support" to the gener


From: no-reply
Subject: Re: [Qemu-devel] [PATCH 0/2] pcie: Add simple ACS "support" to the generic PCIe root port
Date: Thu, 31 Jan 2019 09:49:21 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] pcie: Add simple ACS "support" to the generic 
PCIe root port
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d758b99be0 gen_pcie_root_port: Add ACS (Access Control Services) capability
f09b14c145 pcie: Add a simple PCIe ACS (Access Control Services) helper function

=== OUTPUT BEGIN ===
1/2 Checking commit f09b14c145d7 (pcie: Add a simple PCIe ACS (Access Control 
Services) helper function)
WARNING: line over 80 characters
#30: FILE: hw/pci/pcie.c:917:
+                 PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | PCI_ACS_CR | 
PCI_ACS_UF);

WARNING: line over 80 characters
#32: FILE: hw/pci/pcie.c:919:
+                 PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | PCI_ACS_CR | 
PCI_ACS_UF);

ERROR: code indent should never use tabs
#57: FILE: include/hw/pci/pcie_regs.h:179:
+#define PCI_ACS_VER^I^I^I0x2$

total: 1 errors, 2 warnings, 32 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit d758b99be0f8 (gen_pcie_root_port: Add ACS (Access Control 
Services) capability)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]