qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] spice: set device address and device display ID


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] spice: set device address and device display ID in QXL interface
Date: Thu, 31 Jan 2019 09:50:52 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] spice: set device address and device display ID 
in QXL interface
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c6cf7c9c22 spice: set device address and device display ID in QXL interface

=== OUTPUT BEGIN ===
WARNING: Block comments use a leading /* on a separate line
#27: FILE: hw/display/qxl.c:279:
+#if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */ && \

WARNING: line over 80 characters
#59: FILE: include/ui/spice-display.h:183:
+bool qemu_spice_fill_device_address(QemuConsole *con, char *device_address, 
size_t size);

WARNING: line over 80 characters
#97: FILE: ui/spice-core.c:888:
+bool qemu_spice_fill_device_address(QemuConsole *con, char *device_address, 
size_t size)

ERROR: line over 90 characters
#99: FILE: ui/spice-core.c:890:
+    DeviceState *dev = DEVICE(object_property_get_link(OBJECT(con), "device", 
&error_abort));

WARNING: line over 80 characters
#100: FILE: ui/spice-core.c:891:
+    PCIDevice *pci = (PCIDevice *) object_dynamic_cast(OBJECT(dev), 
TYPE_PCI_DEVICE);

ERROR: line over 90 characters
#103: FILE: ui/spice-core.c:894:
+        warn_report("Setting device address of a display device to SPICE: Not 
a PCI device.");

total: 2 errors, 4 warnings, 102 lines checked

Commit c6cf7c9c2262 (spice: set device address and device display ID in QXL 
interface) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]