Re: [Qemu-devel] [PATCH v11 00/25] Fixing record/replay and adding reverse debugging

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v11 00/25] Fixing record/replay and adding reverse 
debugging
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f8b44808ef icount: clean up cpu_can_io before jumping to the next block
2f7d94b010 replay: rename step-related variables and functions
e2b261fd4d replay: fix replay shutdown
0a08430306 util/qemu-timer: refactor deadline calculation for external timers
d0c6fd8ab0 replay: document development rules
21f1709992 replay: init rtc after enabling the replay
38aac65d87 replay: add BH oneshot event for block layer
087fc5561f replay: describe reverse debugging in docs/replay.txt
3faa39c207 gdbstub: add reverse continue support in replay mode
1eca2bd3d1 gdbstub: add reverse step support in replay mode
b6c6ec26cc replay: flush rr queue before loading the vmstate
b8a448d7a7 replay: refine replay-time module
46c7820268 replay: implement replay-seek command
982e0daa35 replay: introduce breakpoint at the specified step
4b895e908d replay: introduce info hmp/qmp command
16ea16ff4b qapi: introduce replay.json for record/replay-related stuff
b068dc8c88 replay: provide an accessor for rr filename
bb8c95481b migration: introduce icount field for snapshots
e81b4b6159 qcow2: introduce icount field for snapshots
99b5866912 replay: finish record/replay before closing the disks
3c8bd51b59 replay: don't drain/flush bdrv queue while RR is working
5add07fb21 replay: update docs for record/replay with block devices
36a8e79ba0 replay: disable default snapshot for record/replay
7d3a545b7f block: implement bdrv_snapshot_goto for blkreplay
e07e052488 replay: add missing fix for internal function

=== OUTPUT BEGIN ===
1/25 Checking commit e07e052488e5 (replay: add missing fix for internal 
function)
2/25 Checking commit 7d3a545b7f20 (block: implement bdrv_snapshot_goto for 
blkreplay)
3/25 Checking commit 36a8e79ba016 (replay: disable default snapshot for 
record/replay)
4/25 Checking commit 5add07fb219c (replay: update docs for record/replay with 
block devices)
5/25 Checking commit 3c8bd51b5959 (replay: don't drain/flush bdrv queue while 
RR is working)
6/25 Checking commit 99b5866912b2 (replay: finish record/replay before closing 
the disks)
7/25 Checking commit e81b4b615955 (qcow2: introduce icount field for snapshots)
8/25 Checking commit bb8c95481bee (migration: introduce icount field for 
snapshots)
9/25 Checking commit b068dc8c88a2 (replay: provide an accessor for rr filename)
10/25 Checking commit 16ea16ff4b6f (qapi: introduce replay.json for 
record/replay-related stuff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 78 lines checked

Patch 10/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/25 Checking commit 4b895e908ded (replay: introduce info hmp/qmp command)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#142: 
new file mode 100644

total: 0 errors, 1 warnings, 127 lines checked

Patch 11/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/25 Checking commit 982e0daa3522 (replay: introduce breakpoint at the 
specified step)
13/25 Checking commit 46c7820268e5 (replay: implement replay-seek command)
ERROR: "foo* bar" should be "foo *bar"
#118: FILE: replay/replay-debugging.c:134:
+                                          int64_t* snapshot_icount)

total: 1 errors, 0 warnings, 155 lines checked

Patch 13/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/25 Checking commit b8a448d7a70f (replay: refine replay-time module)
15/25 Checking commit b6c6ec26cca5 (replay: flush rr queue before loading the 
vmstate)
16/25 Checking commit 1eca2bd3d1e3 (gdbstub: add reverse step support in replay 
mode)
17/25 Checking commit 3faa39c2076b (gdbstub: add reverse continue support in 
replay mode)
18/25 Checking commit 087fc5561f86 (replay: describe reverse debugging in 
docs/replay.txt)
19/25 Checking commit 38aac65d879d (replay: add BH oneshot event for block 
layer)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#316: 
new file mode 100644

total: 0 errors, 1 warnings, 224 lines checked

Patch 19/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/25 Checking commit 21f1709992d5 (replay: init rtc after enabling the replay)
21/25 Checking commit d0c6fd8ab088 (replay: document development rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 46 lines checked

Patch 21/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/25 Checking commit 0a0843030670 (util/qemu-timer: refactor deadline 
calculation for external timers)
23/25 Checking commit e2b261fd4da3 (replay: fix replay shutdown)
24/25 Checking commit 2f7d94b010c1 (replay: rename step-related variables and 
functions)
WARNING: line over 80 characters
#117: FILE: replay/replay-debugging.c:246:
+        replay_seek(replay_get_current_icount() - 1, replay_stop_vm_debug, 
&err);

total: 0 errors, 1 warnings, 282 lines checked

Patch 24/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/25 Checking commit f8b44808eff1 (icount: clean up cpu_can_io before jumping 
to the next block)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden