[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci

From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file
Date: Thu, 31 Jan 2019 19:00:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-31 18:56, Cornelia Huck wrote:
> On Thu, 31 Jan 2019 18:47:08 +0100
> Thomas Huth <address@hidden> wrote:
>> The arguments of the stub functions to not match the real implementation
> s/to/do/


>> (and the prototypes in the header) anymore, so if you try to compile s390x
>> without CONFIG_PCI, the build currently fails.
> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  hw/s390x/s390-pci-stub.c | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
> This file seems to be in danger of bitrot. Do you think it'll be easier
> to test rarely used configs like that after we switch to Kconfig?

I hope so, yes. There will be a new --without-default-devices options
for "configure" (which matches "make allnoconfig" from the kernel) - if
we do it right in the Kconfig file for s390x, it should be possible to
catch this problem with that option.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]