Re: [Qemu-devel] [PULL 0/8] Usb 20190130 patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/8] Usb 20190130 patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
92aad5cacd usb-mtp: replace the homebrew write with qemu_write_full
51e833a06a usb-mtp: breakup MTP write into smaller chunks
de75b18c3e usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
7679c26cb4 usb: implement XHCI underrun/overrun events
cff5d20762 usb: XHCI shall not halt isochronous endpoints
0d7e030048 hw/usb: Fix LGPL information in the file headers
40bca2e37e usb: dev-mtp: close fd in usb_mtp_object_readdir()
75b3be5381 usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit 75b3be5381cc (usb: assign unique serial numbers to hid 
devices)
2/8 Checking commit 40bca2e37e79 (usb: dev-mtp: close fd in 
usb_mtp_object_readdir())
3/8 Checking commit 0d7e030048b9 (hw/usb: Fix LGPL information in the file 
headers)
4/8 Checking commit cff5d20762e2 (usb: XHCI shall not halt isochronous 
endpoints)
5/8 Checking commit 7679c26cb43a (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#37: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#46: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#65: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#66: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit de75b18c3e2c (usb-mtp: Reallocate buffer in multiples of 
MTP_WRITE_BUF_SZ)
7/8 Checking commit 51e833a06a8b (usb-mtp: breakup MTP write into smaller 
chunks)
8/8 Checking commit 92aad5cacd28 (usb-mtp: replace the homebrew write with 
qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden