Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] scripts: use git archive in archive-source
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
42fe2deeca scripts: use git archive in archive-source

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#56: FILE: scripts/archive-source.sh:41:
+^Igit submodule update --init "$sm"$

ERROR: code indent should never use tabs
#57: FILE: scripts/archive-source.sh:42:
+^Itest $? -ne 0 && error "failed to update submodule $sm"$

ERROR: code indent should never use tabs
#58: FILE: scripts/archive-source.sh:43:
+^I(cd $sm; git archive --format tar --prefix "$sm/" HEAD) > "$sub_file"$

ERROR: code indent should never use tabs
#59: FILE: scripts/archive-source.sh:44:
+^Itest $? -ne 0 && error "failed to archive submodule $sm"$

ERROR: code indent should never use tabs
#60: FILE: scripts/archive-source.sh:45:
+^Itar --concatenate --file "$tar_file" "$sub_file"$

ERROR: code indent should never use tabs
#61: FILE: scripts/archive-source.sh:46:
+^Itest $? -ne 0 && error "failed append submodule $sm to $tar_file"$

total: 6 errors, 0 warnings, 41 lines checked

Commit 42fe2deecad0 (scripts: use git archive in archive-source) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden