[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI |
Date: |
Thu, 31 Jan 2019 10:21:50 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
c6a6125 tests/tcg/aarch64: Add bti smoke test
d2aa2b0 linux-user/aarch64: Reset btype for syscalls and signals
b986e6c target/arm: Enable BTI for -cpu max
e1caea7 target/arm: Add x-guarded-pages cpu property for user-only
4f7a8dd target/arm: Set btype for indirect branches
3c57957 target/arm: Reset btype for direct branches
7ea1157 target/arm: Default handling of BTYPE during translation
6ac89e2 target/arm: Cache the GP bit for a page in MemTxAttrs
09f79d5 exec: Add target-specific tlb bits to MemTxAttrs
9ad3acc target/arm: Add BT and BTYPE to tb->flags
920eae0 target/arm: Add PSTATE.BTYPE
feb08a6 target/arm: Introduce isar_feature_aa64_bti
=== OUTPUT BEGIN ===
1/12 Checking commit feb08a6fee4a (target/arm: Introduce isar_feature_aa64_bti)
2/12 Checking commit 920eae0614cb (target/arm: Add PSTATE.BTYPE)
3/12 Checking commit 9ad3acceedf5 (target/arm: Add BT and BTYPE to tb->flags)
4/12 Checking commit 09f79d576620 (exec: Add target-specific tlb bits to
MemTxAttrs)
ERROR: spaces prohibited around that ':' (ctx:WxW)
#28: FILE: include/exec/memattrs.h:47:
+ unsigned int target_tlb_bit0 : 1;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#29: FILE: include/exec/memattrs.h:48:
+ unsigned int target_tlb_bit1 : 1;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#30: FILE: include/exec/memattrs.h:49:
+ unsigned int target_tlb_bit2 : 1;
^
total: 3 errors, 0 warnings, 16 lines checked
Patch 4/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/12 Checking commit 6ac89e22c243 (target/arm: Cache the GP bit for a page in
MemTxAttrs)
6/12 Checking commit 7ea1157e0b93 (target/arm: Default handling of BTYPE during
translation)
ERROR: return is not a function, parentheses are not required
#97: FILE: target/arm/translate-a64.c:13757:
+ return (tlb_hit(entry->addr_code, addr) &&
total: 1 errors, 0 warnings, 196 lines checked
Patch 6/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit 3c57957c9f30 (target/arm: Reset btype for direct branches)
8/12 Checking commit 4f7a8dd8bbd3 (target/arm: Set btype for indirect branches)
9/12 Checking commit e1caea7ca5ad (target/arm: Add x-guarded-pages cpu property
for user-only)
10/12 Checking commit b986e6c3f551 (target/arm: Enable BTI for -cpu max)
11/12 Checking commit d2aa2b0d2cec (linux-user/aarch64: Reset btype for
syscalls and signals)
12/12 Checking commit c6a612538e4c (tests/tcg/aarch64: Add bti smoke test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
ERROR: externs should be avoided in .c files
#116: FILE: tests/tcg/aarch64/bti-crt.inc.c:13:
+int main(void);
total: 1 errors, 1 warnings, 128 lines checked
Patch 12/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v2 04/12] exec: Add target-specific tlb bits to MemTxAttrs, (continued)
- [Qemu-devel] [PATCH v2 04/12] exec: Add target-specific tlb bits to MemTxAttrs, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 12/12] tests/tcg/aarch64: Add bti smoke test, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 10/12] target/arm: Enable BTI for -cpu max, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 06/12] target/arm: Default handling of BTYPE during translation, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 07/12] target/arm: Reset btype for direct branches, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 02/12] target/arm: Add PSTATE.BTYPE, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 11/12] linux-user/aarch64: Reset btype for syscalls and signals, Richard Henderson, 2019/01/28
- [Qemu-devel] [PATCH v2 03/12] target/arm: Add BT and BTYPE to tb->flags, Richard Henderson, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI, no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI, no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI,
no-reply <=
- Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI, no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI, no-reply, 2019/01/31