[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1) |
Date: |
Thu, 31 Jan 2019 10:51:48 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
34e5680bef Merge remote-tracking branch
'remotes/kraxel/tags/usb-20190130-pull-request' into staging
8387d5c617 usb-mtp: replace the homebrew write with qemu_write_full
ca70aac48e usb-mtp: breakup MTP write into smaller chunks
c1d948a8f3 usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
b6ed7ffc92 usb: implement XHCI underrun/overrun events
0cfbf2b7e4 usb: XHCI shall not halt isochronous endpoints
67b463b634 hw/usb: Fix LGPL information in the file headers
f315447337 usb: dev-mtp: close fd in usb_mtp_object_readdir()
d4158454b1 usb: assign unique serial numbers to hid devices
=== OUTPUT BEGIN ===
1/8 Checking commit d4158454b1c1 (usb: assign unique serial numbers to hid
devices)
2/8 Checking commit f31544733723 (usb: dev-mtp: close fd in
usb_mtp_object_readdir())
3/8 Checking commit 67b463b6342e (hw/usb: Fix LGPL information in the file
headers)
4/8 Checking commit 0cfbf2b7e404 (usb: XHCI shall not halt isochronous
endpoints)
5/8 Checking commit b6ed7ffc92a8 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#39: FILE: hw/usb/hcd-xhci.c:1960:
+ xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
^
ERROR: spaces required around that '-' (ctx:VxV)
#48: FILE: hw/usb/hcd-xhci.c:2041:
+ xhci->slots[slotid-1].intr = 0;
^
ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2316:
+ xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
^
ERROR: spaces required around that '-' (ctx:VxV)
#68: FILE: hw/usb/hcd-xhci.c:2317:
+ set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
^
total: 4 errors, 0 warnings, 48 lines checked
Patch 5/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/8 Checking commit c1d948a8f35e (usb-mtp: Reallocate buffer in multiples of
MTP_WRITE_BUF_SZ)
7/8 Checking commit ca70aac48e0d (usb-mtp: breakup MTP write into smaller
chunks)
8/8 Checking commit 8387d5c6178c (usb-mtp: replace the homebrew write with
qemu_write_full)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1), Stefan Berger, 2019/01/21
- [Qemu-devel] [PATCH 4/4] tpm: Make sure the locality received from backend is valid, Stefan Berger, 2019/01/21
- [Qemu-devel] [PATCH 3/4] tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid, Stefan Berger, 2019/01/21
- [Qemu-devel] [PATCH 2/4] tpm: use loop iterator to set sts data field, Stefan Berger, 2019/01/21
- [Qemu-devel] [PATCH 1/4] tpm: Zero-init structure to avoid uninitialized variables in valgrind log, Stefan Berger, 2019/01/21
- Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1), no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1), no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1), no-reply, 2019/01/31
- Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1),
no-reply <=
- Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1), no-reply, 2019/01/31