[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU |
Date: |
Thu, 31 Jan 2019 14:22:44 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a79752a kconfig: introduce CONFIG_TEST_DEVICES
c9d0fe6 i386-softmmu.mak: remove all CONFIG_* except boards definitions
6f1e6af isa: express SuperIO dependencies with Kconfig
dc95811 tpm: express dependencies with Kconfig
af23f11 virtio: express virtio dependencies with Kconfig
fc253a0 vfio: express vfio dependencies with Kconfig
04964ca hyperv: express dependencies with kconfig
0e23a1e display: express dependencies with kconfig
8d0e47d ptimer: express dependencies with Kconfig
70ffc63 i2c: express dependencies with Kconfig
1b10271 i386: express dependencies with Kconfig
4d30a49 isa: express dependencies with kconfig
f4d520f scsi: express dependencies with Kconfig
3646562 build: convert usb.mak to Kconfig
47589bd build: convert sound.mak to Kconfig
b96574e build: convert pci.mak to Kconfig
8cc438c hw/pci/Makefile.objs: make pcie configurable
fcc8bb5 ide: express dependencies with Kconfig
860ef3a minikconf: implement allnoconfig and defconfig
934e485 build: switch to Kconfig
d253933 kconfig: introduce kconfig files
47c5e5d hw/display: make edid configurable
3c7f935 minikconfig: add semantic analysis
36b08f2 minikconfig: add AST
1ad0a25 minikconfig: add parser skeleton
1733dbf hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and
PCI
b863897 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI
controller
c91ddd4 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
a9bf8be hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
d2cdd2a hw/moxie/Makefile.objs: Conditionally build moxie
892410c hw/hppa/Makefile.objs: Create CONFIG_* for hppa
ae6333d hw/cris/Makefile.objs: Create CONFIG_* for cris
b9d2911 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
3c3acae hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
0a96788 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
530165e hw/nios2/Makefile.objs: Conditionally build nios2
fbaef04 hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally
9043ba2 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
811303a hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
2f7135f hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards
and devices
af8b566 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and
device
cecc461 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
4bf7173 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
6aed799 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx
boards
3997152 hw/m68k/Makefile.objs: Conditionally build boards
530a866 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
fa54373 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
1b6abb7 build: actually use CONFIG_PAM
f6b12fb hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
14d967c vfio: move conditional up to hw/Makefile.objs
bfa4428 ide: split ioport registration to a separate file
305912d arm: disable CONFIG_SERIAL_ISA
=== OUTPUT BEGIN ===
1/52 Checking commit 305912d25e1c (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit bfa4428a4fa5 (ide: split ioport registration to a separate
file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+ /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+ bridge has been setup properly to always register with ISA. */
WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+ bridge has been setup properly to always register with ISA. */
total: 0 errors, 4 warnings, 113 lines checked
Patch 2/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 14d967c0bd06 (vfio: move conditional up to
hw/Makefile.objs)
4/52 Checking commit f6b12fb162a0 (hw/pci-host/Makefile.objs: make CONFIGS
clear for PCI EXPRESS)
5/52 Checking commit 1b6abb71d515 (build: actually use CONFIG_PAM)
6/52 Checking commit fa5437321983 (hw/i386/Makefile.objs: Build pc_piix* and
pc_q35 boards)
7/52 Checking commit 530a8668373d (hw/arm/Makefile.objs: CONFIG_VIRT created
for virt board)
8/52 Checking commit 3997152f27e5 (hw/m68k/Makefile.objs: Conditionally build
boards)
9/52 Checking commit 6aed799dc5f7 (hw/microblaze/Makefile.objs: Create configs
for petalogix and xilinx boards)
10/52 Checking commit 4bf7173a1c3b (hw/mips/Makefile.objs: Create CONFIG_* for
r4k, malta, mipssim boards)
11/52 Checking commit cecc461ab2ff (hw/ppc/Makefile.objs: Build all boards
conditinally with CONFIG_*)
12/52 Checking commit af8b56692c82 (hw/sh4/Makefile.objs: New CONFIG_*
varibales created for sh4 boards and device)
13/52 Checking commit 2f7135f01ea8 (hw/s390/Makefile.objs: Create new CONFIG_*
variables for s390x boards and devices)
14/52 Checking commit 811303a984b6 (hw/sparc/Makefile.objs: CONFIG_* for sun4m
and leon3 created)
15/52 Checking commit 9043ba2da95a (hw/lm32/Makefile.objs: Conditionally build
lm32 and milkmyst)
16/52 Checking commit fbaef04334c1 (hw/xtensa/Makefile.objs: Build xtensa_sim
and xtensa_fpga conditionally)
17/52 Checking commit 530165e2ef75 (hw/nios2/Makefile.objs: Conditionally build
nios2)
18/52 Checking commit 0a967880791e (hw/riscv/Makefile.objs: Create CONFIG_* for
riscv boards)
19/52 Checking commit 3c3acae8cd40 (hw/sparc64/Makefile.objs: Create CONFIG_*
for sparc64)
20/52 Checking commit b9d2911c9dd6 (hw/alpha/Makefile.objs: Create CONFIG_* for
alpha)
21/52 Checking commit ae6333d37354 (hw/cris/Makefile.objs: Create CONFIG_* for
cris)
22/52 Checking commit 892410c5e9bd (hw/hppa/Makefile.objs: Create CONFIG_* for
hppa)
23/52 Checking commit d2cdd2af82d2 (hw/moxie/Makefile.objs: Conditionally build
moxie)
24/52 Checking commit a9bf8be75a10 (hw/openrisc/Makefile.objs: Create CONFIG_*
for openrisc)
25/52 Checking commit c91ddd4eaaef (hw/tricore/Makefile.objs: Create CONFIG_*
for tricore)
26/52 Checking commit b863897de362 (hw/i2c/Makefile.objs: Create new CONFIG_*
variables for EEPROM and ACPI controller)
27/52 Checking commit 1733dbf5ab13 (hw/vfio/Makefile.objs: Create new CONFIG_*
variables for VFIO core and PCI)
28/52 Checking commit 1ad0a25337cc (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+ 'Expected identifier starting with "CONFIG_"',
TOK_NONE)
WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+ raise KconfigParserError(self, 'expected "source", "config",
identifier, '
WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+ raise KconfigParserError(self, 'expected "source", "config" or
identifier')
ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+ if self.src[self.cursor + length].isalnum() or self.src[self.cursor +
length] == '|':
WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+ while self.src[self.cursor].isalnum() or self.src[self.cursor] ==
'_':
total: 1 errors, 5 warnings, 425 lines checked
Patch 28/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 36b08f2e7a79 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+ return "config %s default %s if %s" % (self.dest, value,
self.cond)
total: 0 errors, 1 warnings, 170 lines checked
Patch 29/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 3c7f935afa91 (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+ raise Exception('contradiction between clauses when setting
%s' % self)
WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+ debug_print(i, "->", [str(x) for x in
self.referenced_vars[i].outgoing])
total: 0 errors, 2 warnings, 223 lines checked
Patch 30/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 47c5e5d25040 (hw/display: make edid configurable)
32/52 Checking commit d2539338157c (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+ print ("%s: at least one argument is required" % argv[0],
file=sys.stderr)
total: 0 errors, 2 warnings, 1363 lines checked
Patch 32/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 934e48569c11 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481:
deleted file mode 100644
total: 0 errors, 1 warnings, 325 lines checked
Patch 33/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 860ef3a709c8 (minikconf: implement allnoconfig and
defconfig)
35/52 Checking commit fcc8bb50ce40 (ide: express dependencies with Kconfig)
36/52 Checking commit 8cc438ca1208 (hw/pci/Makefile.objs: make pcie
configurable)
37/52 Checking commit b96574e95500 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120:
deleted file mode 100644
total: 0 errors, 1 warnings, 472 lines checked
Patch 37/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 47589bdbf26b (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
deleted file mode 100644
total: 0 errors, 1 warnings, 51 lines checked
Patch 38/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit 36465626a31a (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158:
deleted file mode 100644
total: 0 errors, 1 warnings, 157 lines checked
Patch 39/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit f4d520f1f7fc (scsi: express dependencies with Kconfig)
41/52 Checking commit 4d30a49e2660 (isa: express dependencies with kconfig)
42/52 Checking commit 1b10271dfb10 (i386: express dependencies with Kconfig)
43/52 Checking commit 70ffc63c8623 (i2c: express dependencies with Kconfig)
44/52 Checking commit 8d0e47d5b043 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 0e23a1e99a67 (display: express dependencies with kconfig)
46/52 Checking commit 04964cac8397 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
deleted file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 46/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit fc253a074755 (vfio: express vfio dependencies with
Kconfig)
48/52 Checking commit af23f11ab99b (virtio: express virtio dependencies with
Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
deleted file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 48/52 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit dc95811473a1 (tpm: express dependencies with Kconfig)
50/52 Checking commit 6f1e6af4d997 (isa: express SuperIO dependencies with
Kconfig)
51/52 Checking commit c9d0fe6e67ab (i386-softmmu.mak: remove all CONFIG_*
except boards definitions)
52/52 Checking commit a79752a80249 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig, (continued)
- [Qemu-devel] [PATCH 50/52] isa: express SuperIO dependencies with Kconfig, Paolo Bonzini, 2019/01/25
- [Qemu-devel] [PATCH 52/52] kconfig: introduce CONFIG_TEST_DEVICES, Paolo Bonzini, 2019/01/25
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, Yang Zhong, 2019/01/25
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU,
no-reply <=
- Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU, no-reply, 2019/01/31