[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] configure: LM32 Milkymist Texture Mapping Unit (
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 2/5] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11 |
Date: |
Fri, 1 Feb 2019 13:30:57 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Commit 5f9b1e35060b8 remove the dependency between OpenGL and X11.
However the milkymist-tmu2 device do require X11.
When using SDL, the configure script sets need_x11=yes, so the X11
flags are populated to the makefiles.
When building without SDL, X11 is not pulled and populated, leading
to a link failure:
LINK lm32-softmmu/qemu-system-lm32
hw/lm32/milkymist.o: In function `milkymist_tmu2_create':
hw/lm32/milkymist-hw.h:114: undefined reference to `XOpenDisplay'
hw/lm32/milkymist-hw.h:140: undefined reference to `XFree'
hw/lm32/milkymist-hw.h:141: undefined reference to `XCloseDisplay'
hw/lm32/milkymist-hw.h:130: undefined reference to `XCloseDisplay'
../hw/display/milkymist-tmu2.o: In function `tmu2_glx_init':
hw/display/milkymist-tmu2.c:112: undefined reference to `XOpenDisplay'
hw/display/milkymist-tmu2.c:123: undefined reference to `XFree'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:199: qemu-system-lm32] Error 1
Enforce the X11 dependency when the LM32 target is built.
This will allow us to build QEMU without SDL.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
configure | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/configure b/configure
index b18281c61f..c7024d6662 100755
--- a/configure
+++ b/configure
@@ -4047,6 +4047,16 @@ EOF
fi
fi
+if test "$opengl" = "yes" -a "$have_x11" = "yes"; then
+ for target in $target_list; do
+ case $target in
+ lm32-softmmu) # milkymist-tmu2 requires X11 and OpenGL
+ need_x11=yes
+ ;;
+ esac
+ done
+fi
+
##########################################
# libxml2 probe
if test "$libxml2" != "no" ; then
--
2.9.3
- [Qemu-devel] [PULL 0/5] Ui 20190201 patches, Gerd Hoffmann, 2019/02/01
- [Qemu-devel] [PULL 1/5] hw/display: Move Milkymist specific hardware out of common-obj list, Gerd Hoffmann, 2019/02/01
- [Qemu-devel] [PULL 3/5] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL, Gerd Hoffmann, 2019/02/01
- [Qemu-devel] [PULL 2/5] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 4/5] hw/display/milkymist-tmu2: Move inlined code from header to source, Gerd Hoffmann, 2019/02/01
- [Qemu-devel] [PULL 5/5] ui: remove support for SDL1.2 in favour of SDL2, Gerd Hoffmann, 2019/02/01
- Re: [Qemu-devel] [PULL 0/5] Ui 20190201 patches, Peter Maydell, 2019/02/01
- Re: [Qemu-devel] [libvirt] [PULL 0/5] Ui 20190201 patches, no-reply, 2019/02/03