[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qtest.py: Wait for the result of qtest commands
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH] qtest.py: Wait for the result of qtest commands |
Date: |
Fri, 1 Feb 2019 15:12:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 31.01.19 13:38, Alberto Garcia wrote:
> The cmd() method of the QEMUQtestProtocol class sends a qtest command
> to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
> Because of this, it can return control to the caller before the
> command has actually finished.
>
> In cases like clock_step or clock_set this means that cmd() can return
> before all the timers triggered by the clock change have been fired.
> This can be fixed by making cmd() wait for the output of the qtest
> command.
>
> This fixes iotests 093 and 136, which are flaky since commit
> 8258292e18c39480b64eba9f3551 when the machine is under heavy workload.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> scripts/qtest.py | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks a lot!
Max
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] qtest.py: Wait for the result of qtest commands,
Max Reitz <=