[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v13 16/31] quorum: Make bdrv_dirname() return NULL
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v13 16/31] quorum: Make bdrv_dirname() return NULL |
Date: |
Fri, 1 Feb 2019 20:29:20 +0100 |
While the common implementation for bdrv_dirname() should return NULL
for quorum BDSs already (because they do not have a file node and their
exact_filename field should be empty), there is no reason not to make
that explicit.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/quorum.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index cf9d7c16c2..a890f21e85 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1094,6 +1094,16 @@ static void quorum_refresh_filename(BlockDriverState
*bs, QDict *options)
bs->full_open_options = opts;
}
+static char *quorum_dirname(BlockDriverState *bs, Error **errp)
+{
+ /* In general, there are multiple BDSs with different dirnames below this
+ * one; so there is no unique dirname we could return (unless all are equal
+ * by chance, or there is only one). Therefore, to be consistent, just
+ * always return NULL. */
+ error_setg(errp, "Cannot generate a base directory for quorum nodes");
+ return NULL;
+}
+
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
@@ -1102,6 +1112,7 @@ static BlockDriver bdrv_quorum = {
.bdrv_open = quorum_open,
.bdrv_close = quorum_close,
.bdrv_refresh_filename = quorum_refresh_filename,
+ .bdrv_dirname = quorum_dirname,
.bdrv_co_flush_to_disk = quorum_co_flush,
--
2.20.1
- [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull, (continued)
- [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 09/31] block: Make path_combine() return the path, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 08/31] iotests: Add test for backing file overrides, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 12/31] block: Add bdrv_make_absolute_filename(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 11/31] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 13/31] block: Fix bdrv_find_backing_image(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 14/31] block: Add bdrv_dirname(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 16/31] quorum: Make bdrv_dirname() return NULL,
Max Reitz <=
- [Qemu-devel] [PATCH v13 15/31] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 18/31] block/nfs: Implement bdrv_dirname(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 17/31] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 19/31] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 20/31] iotests: Add quorum case to test 110, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 22/31] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 21/31] block: Add strong_runtime_opts to BlockDriver, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 28/31] block/curl: Implement bdrv_refresh_filename(), Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 29/31] block/null: Generate filename even with latency-ns, Max Reitz, 2019/02/01
- [Qemu-devel] [PATCH v13 26/31] block/nvme: Fix bdrv_refresh_filename(), Max Reitz, 2019/02/01