[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] queue: fix QTAILQ_FOREACH_REVERSE_SAFE
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] queue: fix QTAILQ_FOREACH_REVERSE_SAFE |
Date: |
Mon, 4 Feb 2019 16:27:02 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/4/19 3:43 PM, Paolo Bonzini wrote:
> The iteration was stopping as soon as prev_var was set to NULL, and
> therefore it skipped the first element. Fortunately, or unfortunately,
> we have only one use of QTAILQ_FOREACH_REVERSE_SAFE. Thus this only
> showed up as incorrect register preferences on the very first translation
> block that was compiled.
>
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/qemu/queue.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~