[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from th
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports |
Date: |
Tue, 5 Feb 2019 16:17:25 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Feb 05, 2019 at 04:09:24PM +0000, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <address@hidden> writes:
>
> > Various iotests scripts (run via 'make check-block') use bash
> > specific extentions. OpenBSD comes with the Korn shell as default.
> > Install bash to be able to run those tests.
>
> Hmmm given we use plain POSIX shell for configure portability is there a
> reason the check-block test scripts use bash? I guess it doesn't get
> picked up as check-block isn't run normally.
configure requests any POSIX shell (#!/bin/sh) & aim for portability.
The block iotests though made an explicit choice not to care for POSIX
shell portability and so explicitly request bash (#!/bin/bash).
The block iotests are not something we expect every user of QEMU
to run, so it is valid to have a more specific requirement for
executing them, than is required by configure for general purpose
build + unit tests.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, (continued)
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Gerd Hoffmann, 2019/02/06
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Peter Maydell, 2019/02/06
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Brad Smith, 2019/02/06
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Alex Bennée, 2019/02/06
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Brad Smith, 2019/02/06
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Alex Bennée, 2019/02/07
Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports, Alex Bennée, 2019/02/05
- Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports,
Daniel P . Berrangé <=