[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosit
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity |
Date: |
Wed, 6 Feb 2019 10:23:53 +0100 |
User-agent: |
NeoMutt/20180716 |
On Mon, Feb 04, 2019 at 09:45:17PM +0100, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
> default:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
> hw/input/tsc210x.c:638:5: error: label at end of compound statement
> bad_reg:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
> hw/input/tsc210x.c:766:5: error: label at end of compound statement
> default:
> ^~~~~~~
> make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
>
> Fix this by replacing the culprit fprintf(stderr) calls by a more
> recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
> are left untouched.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/input/tsc210x.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
Reviewed-by: Stefano Garzarella <address@hidden>