Re: [Qemu-devel] [PATCH v3 0/8] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

[Igor Mammedov]

On Thu, 31 Jan 2019 15:16:50 +0800
Tao Xu <address@hidden> wrote:

> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to the System Physical Address (SPA) Memory Ranges.
> The software is expected to use this information as hint for optimization.
> 
> OSPM evaluates HMAT only during system initialization. Any changes to the HMAT
> state at runtime or information regarding HMAT for hot plug are communicated
> using the _HMA method.
> 
> From 1 to 6 patches are the former V1 patches. From 7 to 8 patches are the
> updates per Igor and Eric's comments.
> 
> The V2 patches link:
> http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02276.html
> The V1 RESEND patches link:
> http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg05368.html

pls, use build_append_int_noprefix() to build parts of ACPI table in all patches

> 
> Changelog:
> v3:
>   Per Eric's comments
>     - rebase the fixing patch into the jingqi's patches
>     - update the version tag from 3.10 to 4.0
> v2:
>   Per Igor and Eric's comments, fix some coding style and small issues:
>     - update the version number in qapi/misc.json
>     - including the expansion of the acronym HMAT in qapi/misc.json
>     - correct spell mistakes in qapi/misc.json and qemu-options.hx
>     - fix the comment syle in hw/i386/acpi-build.c
>     and hw/acpi/hmat.h
>    - remove some unnecessary head files in hw/acpi/hmat.c
>    - use hardcoded numbers from spec to generate
>    Memory Subsystem Address Range Structure in hw/acpi/hmat.c
>    - drop the struct AcpiHmat and AcpiHmatSpaRange
>     in hw/acpi/hmat.h
>   Per Igor's comment, rewrite NFIT code to build _HMA method.
> 
> Liu Jingqi (6):
>   hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI
>     HMAT
>   hmat acpi: Build System Locality Latency and Bandwidth Information
>     Structure(s) in ACPI HMAT
>   hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI
>     HMAT
>   Extend the command-line to provide memory latency and bandwidth
>     information
>   numa: Extend the command-line to provide memory side cache information
>   hmat acpi: Implement _HMA method to update HMAT at runtime
> 
> Tao Xu (2):
>   hmat acpi: move some function inside of the caller
>   acpi: rewrite the _FIT method to use it in _HMA method
> 
>  default-configs/i386-softmmu.mak |   1 +
>  hw/acpi/Makefile.objs            |   1 +
>  hw/acpi/hmat.c                   | 424 +++++++++++++++++++++++++++++++
>  hw/acpi/hmat.h                   | 245 ++++++++++++++++++
>  hw/acpi/nvdimm.c                 | 389 ++++++++++++++++++----------
>  hw/i386/acpi-build.c             | 125 +++++----
>  hw/i386/acpi-build.h             |  10 +
>  hw/i386/pc.c                     |   2 +
>  hw/i386/pc_piix.c                |   3 +
>  hw/i386/pc_q35.c                 |   3 +
>  include/hw/i386/pc.h             |   2 +
>  include/hw/mem/nvdimm.h          |  11 +
>  include/sysemu/numa.h            |   2 +
>  numa.c                           | 202 +++++++++++++++
>  qapi/misc.json                   | 162 +++++++++++-
>  qemu-options.hx                  |  28 +-
>  16 files changed, 1427 insertions(+), 183 deletions(-)
>  create mode 100644 hw/acpi/hmat.c
>  create mode 100644 hw/acpi/hmat.h
>