[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf |
Date: |
Wed, 6 Feb 2019 11:32:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
Did you just do a manual search for candidate callers?
As you said in the cover letter, there are other files that can benefit
as well; are you planning on making v3 of the series longer?
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/io.c | 90 +++++++++++++-----------------------------------------
> 1 file changed, 21 insertions(+), 69 deletions(-)
But I'm loving the diffstat - it is definitely a nice change.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature